Replaced some jQuery with vanilla javascript#26431
Open
StefanSpieker wants to merge 1 commit intojenkinsci:masterfrom
Open
Replaced some jQuery with vanilla javascript#26431StefanSpieker wants to merge 1 commit intojenkinsci:masterfrom
StefanSpieker wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Member
|
Set a system property: That will bypass the development skip I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced some
jQuerywith vanilla JavaScript. Starting simple, there is a lot jQuery in this file.The intention is not to change anything, just use more modern JavaScript, this might also improve the performance.
Testing done
I'm having difficulties starting the plugin wizard in development environment. Does anyone have a clue how get it started in debugger?
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@timja or @janfaracik
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.